This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix: core aria property types #6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mark aria props as any to enable compatibility with TS < 4.3 and 4.3+ Signed-off-by: Cory Rylan <[email protected]>
mathisscott
approved these changes
Nov 11, 2021
hippee-lee
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
This is a follow up fix to PR #6456 It looks like my initial thought and testing to override the aria property type defs was wrong. The way to work around this for now is to just cast them as
any. Once TS fixes the dom types then we can update TS in v6. Until then this is the workaround. This unblocks PR #6455Does this PR introduce a breaking change?
Other information