Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Create migration for new BTREE index on check_order column of version… #232

Closed
wants to merge 1 commit into from

Conversation

christophermancini
Copy link

@christophermancini christophermancini commented Dec 7, 2017

…_resources table.

This PR replaced #218

@vito
Copy link
Contributor

vito commented Dec 12, 2017

Looks good, just leaving a comment to kick the CI build and give it another shot. Looks like a flake.

@vito
Copy link
Contributor

vito commented Jan 11, 2018

Dang, looks like I forgot to merge this after kicking the build. Would you mind rebasing to resolve the bindata conflict?

(Note to self: bindata is probably gonna be a pain point for PRs going forward - maybe we should investigate building it in the pipeline instead.)

@mhuangpivotal
Copy link
Contributor

Hi @christophermancini, I took the liberty to merge this manually. Thanks!

@mhuangpivotal mhuangpivotal deleted the check_order_index branch May 4, 2018 14:32
@vito
Copy link
Contributor

vito commented Jun 5, 2018

We had to roll this back as it caused significant performance issues on our large-scale environment (Wings). We're not 100% sure why, but things perform better without this index. Pretty surprising!

I'm going to capture an optimization for this in concourse/rfcs#1 under the "Implementation Notes" section at the bottom. It'll be even more important once we have the new interface, as it'll be checking across multiple spaces and with many more versions in the history (all of'em).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants