[multi-asic] skip the neighbor check if the neighbor is ASIC(sonic-ne…

…t#3908)

What is the motivation for this PR?
Currently the test test_nbr_health is failing on multi asic platform.
This is because the test tries to incorrectly tries to find internal neighbors in nbrhost list for the DUT.

How did you do it?
exclude internal neigbors from the check in the test

How did you verify/test it?
run the tests in test_nbr_health.py on single and multi asic platforms

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>

tests/test_nbr_health.py

@@ -88,11 +88,12 @@ def test_neighbors_health(duthosts, localhost, nbrhosts, eos, sonic, enum_fronte
         dut_type = dev_meta["localhost"]["type"]
 
     for k, v in nei_meta.items():
-        if v['type'] in ['SmartCable', 'Server'] or dut_type == v['type']:
+        if v['type'] in ['SmartCable', 'Server', 'Asic'] or dut_type == v['type']:
             # Smart cable doesn't respond to snmp, it doesn't have BGP session either.
             # DualToR has the peer ToR listed in device as well. If the device type
             # is the same as testing DUT, then it is the peer.
             # The server neighbors need to be skipped too.
+            # Skip if the neigbhor is asic as well.
             continue
 
         nbrhost = nbrhosts[k]['host']