upgraded jmte version to 5.0.0 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed Renderers to reflect new method signature changed HtmlResult to call new Static Factory Method
|
well there is a test failing, i tried to resolve the old version of asm mentioned in #271 as the newest version of jmte now uses a newer version of asm. |
BSchneppe
commented
Feb 3, 2020
added 2 commits
February 4, 2020 10:46
…n TestSuite and adding it to the model update result.html accordingly
|
Thank you for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed Renderers to reflect new method signature
changed HtmlResult to call new Static Factory Method
Compilation has been tested, but not every Renderer, however logic has not been touched