Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia): Update nvml.h #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhundven
Copy link
Contributor

This file is updated from:
https://anaconda.org/nvidia/cuda-nvml-dev/files
https://anaconda.org/nvidia/cuda-nvml-dev/12.6.77/download/linux-64/cuda-nvml-dev-12.6.77-2.conda

unzip cuda-nvml-dev-12.6.77-2.conda
tar --zstd -xf pkg-cuda-nvml-dev-12.6.77-2.tar.zst
cp targets/x86_64-linux/include/nvml.h path/to/thinkfan/include/nvidia/gdk/nvml.h

This file is updated from:
https://anaconda.org/nvidia/cuda-nvml-dev/files
https://anaconda.org/nvidia/cuda-nvml-dev/12.6.77/download/linux-64/cuda-nvml-dev-12.6.77-2.conda

```sh
unzip cuda-nvml-dev-12.6.77-2.conda
tar --zstd -xf pkg-cuda-nvml-dev-12.6.77-2.tar.zst
cp targets/x86_64-linux/include/nvml.h path/to/thinkfan/include/nvidia/gdk/nvml.h
```
@bhundven
Copy link
Contributor Author

Tested on Fedora Workstation 41

@bhundven
Copy link
Contributor Author

I also verified that there is no difference (for now) between the x86_64 and aarch64 nvml.h headers:

$ diff -u aarch64/targets/sbsa-linux/include/nvml.h x86_64/targets/x86_64-linux/include/nvml.h 
$

@bhundven
Copy link
Contributor Author

@vmatare
Copy link
Owner

vmatare commented Oct 16, 2024

Thanks, but what exactly is the motivation for updating? I'm very aware that this old header is probably missing a lot of newer stuff (which we don't need), but I figured that that's a good thing, because that keeps it compatible with both very old and new driver libs, whereas a new header will only be compatible with new libs...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants