[Frontend] Add max_tokens prometheus metric #9881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeras91
requested review from
DarkLight1337,
robertgshaw2-neuralmagic,
simon-mo,
WoosukKwon,
zhuohan123,
youkaichao,
alexm-neuralmagic,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
…kens requested by the user, which is generally different than the number of tokens actually generated Signed-off-by: Tomer Asida <[email protected]>
Signed-off-by: Tomer Asida <[email protected]>
Signed-off-by: Tomer Asida <[email protected]>
tomeras91
force-pushed
the
add-max-tokens-metric
branch
from
f842335
to
9267cd0
Compare
|
@robertgshaw2-neuralmagic can you review this? |
simon-mo
approved these changes
Nov 4, 2024
github-actions
bot
added
the
ready
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Tomer Asida <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Tomer Asida <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
richardsliu
pushed a commit
to richardsliu/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Tomer Asida <[email protected]> Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151
pushed a commit
to bigPYJ1151/vllm
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Tomer Asida <[email protected]>
DarkLight1337
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Tomer Asida <[email protected]>
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Tomer Asida <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Tomer Asida <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds reporting of
max_tokensas a prometheus metric (histogram) -vllm:request_params_max_tokens.The number of generated tokens is already reported (
vllm:request_generation_tokens), but that's the number of tokens actually generated, which is generally different from the number of tokens requested by the user -max_tokens