Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/build] Pin CI dependencies version with pip-compile #9810

Merged
merged 4 commits into from
Oct 30, 2024
Merged

[ci/build] Pin CI dependencies version with pip-compile #9810

merged 4 commits into from
Oct 30, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Oct 29, 2024

Due to recent CI failures related to new releases from CI dependencies, we should freeze all direct & underlying dependencies and update them periodically (once a week)

This PR moves all dependencies to requirements-test.in and generate requirements-test.txt using pip-compile with python 3.12 (same version being used on CI build). Also, transformers is pinned to 4.45.2 for now.
Next step is to configure GHA workflow (dependabot) to perform this pip compile once a week.

@khluu
p
1b51079 
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from simon-mo October 29, 2024 19:53
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Oct 29, 2024
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2024
@khluu
Copy link
Collaborator Author

khluu commented Oct 29, 2024 •
edited
Loading

looks like requirements-test.txt is overriding requirements-common.txt, numpy is 2.0.2 even when requirements-common.txt limits it to < 2.0.0

@khluu
Copy link
Collaborator Author

khluu commented Oct 29, 2024

Also pin torch==2.5.0 and numpy < 2.0.0 in requirements-test.in

@khluu
p
1e3ac21 
Signed-off-by: kevin <[email protected]>
@khluu
upgrade pip amd
6d67261 
Signed-off-by: kevin <[email protected]>
@khluu
p
5a7c27c 
Signed-off-by: kevin <[email protected]>
@khluu khluu enabled auto-merge (squash) October 29, 2024 22:32
@khluu khluu merged commit 62fac4b into main Oct 30, 2024
80 checks passed
@khluu khluu deleted the khluu/pip_compile branch October 30, 2024 03:34
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
@khluu @rasmith
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
3258a07 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@khluu @NickLucche
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
d215651 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@khluu @NickLucche
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
7cf22ab 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: NickLucche <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@khluu
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
b1eb0fc 
…#9810)

Signed-off-by: kevin <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@khluu
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
87c2a9e 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@khluu @hissu-hyvarinen
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
bb26078 
…#9810)

Signed-off-by: kevin <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@khluu @JC1DA
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
43ab49c 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@khluu @sumitd2
[ci/build] Pin CI dependencies version with pip-compile (vllm-project…
dbd7592 
…#9810)

Signed-off-by: kevin <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khluu @simon-mo