Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) #9801

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) #9801

merged 2 commits into from
Oct 29, 2024

Conversation

yannicks1
Copy link
Contributor

Renaming classes to fix typo: casualLM -> causalLM
FIX #9799
OpenVINOCasualLM -> OpenVINOCausalLM
NeuronCasualLM -> NeuronCausalLM

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yannicks1 yannicks1 changed the title Typo fix: Renaming classes (casualLM -> causalLM) [Misc]: Typo fix: Renaming classes (casualLM -> causalLM) Oct 29, 2024
russellb
russellb suggested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. :-)

Can you update your commit messages to include a Signed-off-by header? You can use git commit --amend -s to add it automatically to a given commit.

mgoin
mgoin approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can manually sign for you if the checks are green

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2024
@yannicks1
Copy link
Contributor Author

thanks, I did update my commit messages to include the Signed-off-by header.

russellb
russellb approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simon-mo simon-mo merged commit 0ce7798 into vllm-project:main Oct 29, 2024
53 of 56 checks passed
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
@yannicks1 @rasmith
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
f7ad7e0 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@yannicks1 @NickLucche
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
0c13e4c 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@yannicks1 @NickLucche
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
b531423 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: NickLucche <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@yannicks1
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
785b5e1 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@yannicks1
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
f08a2b2 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@yannicks1 @hissu-hyvarinen
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
b1e6880 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@yannicks1 @JC1DA
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
d0f5f73 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@yannicks1 @sumitd2
[Misc]: Typo fix: Renaming classes (casualLM -> causalLM) (vllm-proje…
ae6019f 
…ct#9801)

Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Misc]: typo: casual instead of causal language model
4 participants
@yannicks1 @russellb @mgoin @simon-mo