Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Use temporary directory in registry #9721

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[Bugfix] Use temporary directory in registry #9721

merged 1 commit into from
Oct 29, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 26, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo simon-mo merged commit eae3d48 into main Oct 29, 2024
71 checks passed
@simon-mo simon-mo deleted the registry-tempdir branch October 29, 2024 05:08
@DarkLight1337 DarkLight1337 mentioned this pull request Oct 30, 2024
Closed
1 task
@xiezhipeng-git xiezhipeng-git mentioned this pull request Oct 30, 2024
Open
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
@DarkLight1337 @rasmith
[Bugfix] Use temporary directory in registry (vllm-project#9721)
d49e85a 
Signed-off-by: Randall Smith <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@DarkLight1337 @NickLucche
[Bugfix] Use temporary directory in registry (vllm-project#9721)
2d42148 
Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@DarkLight1337 @NickLucche
[Bugfix] Use temporary directory in registry (vllm-project#9721)
ea96146 
Signed-off-by: NickLucche <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@DarkLight1337
[Bugfix] Use temporary directory in registry (vllm-project#9721)
48816c1
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@DarkLight1337
[Bugfix] Use temporary directory in registry (vllm-project#9721)
6af24c2 
Signed-off-by: Linkun Chen <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@DarkLight1337 @JC1DA
[Bugfix] Use temporary directory in registry (vllm-project#9721)
6856a99 
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@DarkLight1337 @sumitd2
[Bugfix] Use temporary directory in registry (vllm-project#9721)
d612841 
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
2 participants
@DarkLight1337 @simon-mo