[Core] Refactor: Clean up unused argument preemption_mode in Scheduler._preempt #9696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejonasson
requested review from
WoosukKwon,
zhuohan123,
youkaichao,
alexm-neuralmagic,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
|
please fix the format, thanks! |
…e of parameter. Signed-off-by: André Jonasson <[email protected]>
Signed-off-by: André Jonasson <[email protected]>
|
@youkaichao DCO fixed and format fixed. |
DarkLight1337
pushed a commit
that referenced
this pull request
Nov 2, 2024
Signed-off-by: André Jonasson <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
richardsliu
pushed a commit
to richardsliu/vllm
that referenced
this pull request
Nov 4, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]> Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151
pushed a commit
to bigPYJ1151/vllm
that referenced
this pull request
Nov 5, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]>
DarkLight1337
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: André Jonasson <[email protected]>
DarkLight1337
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: André Jonasson <[email protected]>
hissu-hyvarinen
pushed a commit
to ROCm/vllm
that referenced
this pull request
Nov 6, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]>
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
…-project#9696) Signed-off-by: André Jonasson <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up an unused argument
preemption_modein the functionScheduler._preemptand removes the usage of that unused argument. This PR does not change any existing behaviour.