Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.compile] Adding torch compile annotations to some models #9639

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[torch.compile] Adding torch compile annotations to some models #9639

merged 2 commits into from
Oct 24, 2024

Conversation

CRZbulabula
Copy link
Contributor

This PR is to improve #9589, adding torch compile annotations to some models and testing them.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao self-requested a review as a code owner October 24, 2024 06:49
youkaichao
youkaichao approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@youkaichao youkaichao merged commit 8a02cd0 into vllm-project:main Oct 24, 2024
28 of 31 checks passed
@CRZbulabula CRZbulabula deleted the torch-support-model branch October 24, 2024 09:11
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@CRZbulabula @youkaichao
[torch.compile] Adding torch compile annotations to some models (vllm…
99fc313 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Erkin Sagiroglu <[email protected]>
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
@CRZbulabula @youkaichao @cooleel
[torch.compile] Adding torch compile annotations to some models (vllm…
40e6978 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
@CRZbulabula @youkaichao @cooleel
[torch.compile] Adding torch compile annotations to some models (vllm…
ff220a4 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@CRZbulabula @youkaichao @FerdinandZhong
[torch.compile] Adding torch compile annotations to some models (vllm…
e6c92d9 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: qishuai <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@CRZbulabula @youkaichao @NickLucche
[torch.compile] Adding torch compile annotations to some models (vllm…
0aef088 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@CRZbulabula @youkaichao @NickLucche
[torch.compile] Adding torch compile annotations to some models (vllm…
3f94d5f 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: NickLucche <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@CRZbulabula @youkaichao @sumitd2
[torch.compile] Adding torch compile annotations to some models (vllm…
8dc6d9b 
…-project#9639)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CRZbulabula @youkaichao