[Bugfix] Fix divide by zero when serving Mamba models #9617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrmchlsmth
requested review from
WoosukKwon,
zhuohan123,
youkaichao,
alexm-neuralmagic,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
tlrmchlsmth
force-pushed
the
tms/fix_mamba_divide_by_zero
branch
from
374192e
to
275a587
Compare
`num_total_gpu` ends up being 0 for attention-free models, which results in a divide-by-zero in llm_engine.py when running: ``` vllm serve tiiuae/falcon-mamba-7b-instruct ``` We're already guarding against None here so this guards against zero as well. I also tried setting `num_gpu_blocks` to `None` in `determine_num_available_blocks` but a couple of different spots choked on this. Signed-off-by: Tyler Michael Smith <[email protected]>
tlrmchlsmth
force-pushed
the
tms/fix_mamba_divide_by_zero
branch
from
275a587
to
7e3261d
Compare
DarkLight1337
approved these changes
Oct 23, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: Alvant <[email protected]>
MErkinSag
pushed a commit
to MErkinSag/vllm
that referenced
this pull request
Oct 26, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: Erkin Sagiroglu <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: qishuai <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: NickLucche <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: NickLucche <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_total_gpuends up being 0 for attention-free models, which results in a divide-by-zero in llm_engine.py when running:We're already guarding against None here so this guards against zero as well.
I also tried setting
num_gpu_blockstoNoneindetermine_num_available_blocksbut a couple of different spots choked on this.Closes #7478 (again)