Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix _init_vision_model in NVLM_D model #9611

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[Bugfix] Fix _init_vision_model in NVLM_D model #9611

merged 2 commits into from
Oct 23, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 23, 2024 •
edited
Loading

Oops, just realized that #9217 and #9528 break NVLM_D model. This PR fixes the issue.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 23, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fix _init_vision_model in nvlm_d model [Bugfix] Fix _init_vision_model in NVLM_D model Oct 23, 2024
Isotr0py
Isotr0py approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also forgot that NVLM-D based on InternVL2 models. 😅

vllm/model_executor/models/nvlm_d.py Outdated Show resolved Hide resolved
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 23, 2024 12:19
@DarkLight1337 DarkLight1337 merged commit e7116c0 into main Oct 23, 2024
59 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-nvlm-d branch October 23, 2024 14:28
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@DarkLight1337 @Isotr0py @charlifu
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
d293afa 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: charlifu <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Isotr0py @Alvant
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
81ac865 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Alvant <[email protected]>
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Isotr0py
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
15e022c 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Erkin Sagiroglu <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@DarkLight1337 @Isotr0py @FerdinandZhong
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
c2f2cc7 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: qishuai <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@DarkLight1337 @Isotr0py @NickLucche
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
3fec683 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@DarkLight1337 @Isotr0py @NickLucche
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
b3d73d4 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: NickLucche <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@DarkLight1337 @Isotr0py @sumitd2
[Bugfix] Fix _init_vision_model in NVLM_D model (vllm-project#9611)
98630a2 
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py