Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][Pixtral] Optimizations for input_processor_for_pixtral_hf #9514

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Oct 18, 2024

This PR improves the performance of the Pixtral input processor function a bit.

For new_prompt we split the prompt only once, process images and prompt parts together, and generate new tokens for each image more directly.

For new_token_ids we now find all image tokens at once, process images and tokens together more efficiently, and replace tokens from end to start to avoid index issues.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

# Backward iteration for replacement without affecting known indices
for placeholder_idx, replace_tokens in zip(reversed(placeholder_indices),
reversed(replace_tokens_list)):
new_token_ids[placeholder_idx:placeholder_idx + 1] = replace_tokens
Copy link
Member

@DarkLight1337 DarkLight1337 Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know you could assign slices of a different size to a list, TIL!

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You can merge this once you have tested this using the example script.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 19, 2024
@mgoin
Copy link
Collaborator Author

mgoin commented Oct 19, 2024

I tested with both the example script and a full eval on chartqa, thanks!

I will work on making an integration test for this model since we can directly compare with HF

@mgoin mgoin merged commit 8e3e7f2 into main Oct 19, 2024
69 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@simon-mo simon-mo deleted the optimize-pixtral-hf-processor branch October 28, 2024 16:50
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants