Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Add env variable to force flashinfer backend to enable tensor cores #9497

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Oct 18, 2024

Relates to #9471

We find that the heuristic used to decide when to enable tensor cores in Flashinfer is not working well for llama3.1-8b. While we try to figure out a better one, we propose adding this environment variable to override the logic.

image

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tdoublep tdoublep force-pushed the flashinfer-force-tensor-cores branch from 72a300c to 8de2c18 Compare October 18, 2024 09:45
@tdoublep tdoublep changed the title Add env variable to force flashinfer backend to enable tensor cores [Kernel] Add env variable to force flashinfer backend to enable tensor cores Oct 18, 2024
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Meanwhile, cc @yzh119

vllm/attention/backends/flashinfer.py Outdated Show resolved Hide resolved
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 18, 2024
@comaniac comaniac merged commit 0c9a525 into vllm-project:main Oct 19, 2024
69 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: charlifu <[email protected]>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: Vinay Damodaran <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: Alvant <[email protected]>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
…r cores (vllm-project#9497)

Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Chih-Chieh Yang <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants