-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Support simpler image input format #9478
[Frontend] Support simpler image input format #9478
Conversation
…ai but not show in public doc
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Overall LGTM. Also please add a unit test in Also cc @ywang96 @DarkLight1337 |
Thanks for review! I just addressed comments and added unittest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Please fix the type errors instead of ignoring them.
After that I'll put ready to unblock the rest CI tests.
…use tuple instead of list
Thanks for the reviews! Fixed. |
Signed-off-by: charlifu <[email protected]>
Signed-off-by: Vinay Damodaran <[email protected]>
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
Signed-off-by: qishuai <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Why we make this change:
Some users use a simpler image input format (example below), which we cannot handle properly now:
OpenAI can handle this format well even though they didn't document in the API reference.
Changes:
Modified the input parsing logic to support more content types within the "content" field - string, simpler image_url, simpler audio_url.