Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Support simpler image input format #9478

Merged

Conversation

yue-anyscale
Copy link
Contributor

@yue-anyscale yue-anyscale commented Oct 18, 2024

Why we make this change:
Some users use a simpler image input format (example below), which we cannot handle properly now:

[
  {
    "role": "user",
    "content": [
      "what's the animals in the image?",
      {
        "image_url": "https://animals.com/dog"
      },
      {
        "image_url": "https://animals.com/cat"
      },
      
    ]
  }
]

OpenAI can handle this format well even though they didn't document in the API reference.

Changes:
Modified the input parsing logic to support more content types within the "content" field - string, simpler image_url, simpler audio_url.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac self-assigned this Oct 18, 2024
@yue-anyscale yue-anyscale marked this pull request as ready for review October 18, 2024 18:14
vllm/entrypoints/chat_utils.py Show resolved Hide resolved
vllm/entrypoints/chat_utils.py Outdated Show resolved Hide resolved
@comaniac
Copy link
Collaborator

Overall LGTM. Also please add a unit test in tests/entrypoints/test_chat_utils.py

Also cc @ywang96 @DarkLight1337

@yue-anyscale
Copy link
Contributor Author

Overall LGTM. Also please add a unit test in tests/entrypoints/test_chat_utils.py

Also cc @ywang96 @DarkLight1337

Thanks for review! I just addressed comments and added unittest.

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Please fix the type errors instead of ignoring them.
After that I'll put ready to unblock the rest CI tests.

vllm/entrypoints/chat_utils.py Outdated Show resolved Hide resolved
vllm/entrypoints/chat_utils.py Outdated Show resolved Hide resolved
vllm/entrypoints/chat_utils.py Outdated Show resolved Hide resolved
@yue-anyscale
Copy link
Contributor Author

Overall LGTM. Please fix the type errors instead of ignoring them. After that I'll put ready to unblock the rest CI tests.

Thanks for the reviews! Fixed.

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 18, 2024
@comaniac comaniac merged commit c5eea3c into vllm-project:main Oct 19, 2024
66 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants