Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Support Mamba2 (Codestral Mamba) #9292

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented Oct 11, 2024

Add support for Mamba2. Not thoroughly tested yet, but Codestral Mamba has legible outputs.

Todo:

  • Integration tests
  • Support Chunked Prefill
  • Incorporate mamba_chunk_scan_combined kernel to avoid the dependency on mamba_ssm
  • Fix tensor parallelism
  • Try to refactor the code for Mamba2's mixer layer to look more like Mamba's

Closes #6479

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth
Copy link
Collaborator Author

Notes on current state:

  1. Now that [Kernel][Model] Improve continuous batching for Jamba and Mamba #9189 has landed, need to update the mamba_chunk_scan_combined to take cache indices, so that this PR will work with the updated MambaCacheManager. Until then this PR is not compatible with current main.
  2. TP does seem to work in the present state however I see bad output when using CUDA graphs + custom_all_reduce

1. Format triton kernels
2. Tweak mamba2.py so models converted using transformers util
   src/transformers/models/mamba2/convert_mamba2_ssm_checkpoint_to_pytorch.py
   will run. However they have garbage output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model]: Codestral Mamba
1 participant