Add tests for models #922
Merged
Add tests for models #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
requested changes
Aug 31, 2023
| max_new_tokens=max_tokens) | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
What is the main reason to add @pytest.fixture decorator compared to directly use these runners in the test function?
There was a problem hiding this comment.
To my understanding, there's no good way to import these runners into tests. Please let me know if there is.
|
@zhuohan123 Thanks for your comments. I've updated the PR. PTAL. |
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic tests for the vLLM models (that can run on a single GPU). The tests compare the outputs of HF and vLLM when using greedy sampling. NOTE: vLLM currently does not pass some of the tests.
@zhuohan123 I think you can extend
HfRunnerandVllmRunnerfor the tests for #857.TODOs (in the future PRs):
tensor_parallel_size> 1.