-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model][VLM] Add multi-video support for LLaVA-Onevision #8905
[Model][VLM] Add multi-video support for LLaVA-Onevision #8905
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
FYI I found some problems with the chat template earlier (see #8874). Please double check that you're using the correct chat templates for examples/tests in this PR. |
Sorry for the long wait! Can you add a test with multi-video input so it is easy to verify that this works? |
Sorry for late response. I added a test with multi-video input. |
229d531
to
737e0ea
Compare
I have updated the tests. Could you please review it when you're available? @DarkLight1337 |
Meanwhile let's see if the tests pass CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the tests locally and they pass. Let's run the CI again.
Thanks for your patience!
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: qishuai <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: Randall Smith <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: NickLucche <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: NickLucche <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
…t#8905) Co-authored-by: litianjian <[email protected]> Co-authored-by: DarkLight1337 <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Add multi-video support for LLaVA-Onevision models.
Example