Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix a condition for ignored sequences #867

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

zhuohan123
Copy link
Member

When we ignore a sequence that is too long, we should continue on the remaining waiting sequences.

Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit d2b2eed into main Aug 28, 2023
2 checks passed
randxie pushed a commit to randxie/vllm that referenced this pull request Aug 29, 2023
@zhuohan123 zhuohan123 deleted the fix-ignored-sequences branch August 31, 2023 23:31
liuyanyi pushed a commit to liuyanyi/vllm that referenced this pull request Sep 12, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants