Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix PerTensorScaleParameter weight loading for fused models #7376

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[Bugfix] Fix PerTensorScaleParameter weight loading for fused models #7376

merged 2 commits into from
Aug 9, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Aug 9, 2024 •
edited
Loading

Summary

  • Small update to fix weight loading of PerTensorScaleParameter and BasevLLMParameter for fused models

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka
Copy link
Contributor Author

dsikka commented Aug 9, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 9, 2024
@dsikka dsikka marked this pull request as draft August 9, 2024 19:15
@mgoin mgoin marked this pull request as ready for review August 9, 2024 19:17
@mgoin mgoin enabled auto-merge (squash) August 9, 2024 20:06
@mgoin mgoin merged commit 5c6c54d into vllm-project:main Aug 9, 2024
51 checks passed
@mgoin mgoin deleted the fix-pertensor-wl branch August 9, 2024 21:23
@mgoin mgoin mentioned this pull request Aug 9, 2024
Closed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
@dsikka @sfc-gh-mkeralapura
[Bugfix] Fix PerTensorScaleParameter weight loading for fused models (
4b11fdb 
vllm-project#7376)
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@dsikka @kylesayrs
[Bugfix] Fix PerTensorScaleParameter weight loading for fused models (
a152d61 
vllm-project#7376)
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
@dsikka @fialhocoelho
[Bugfix] Fix PerTensorScaleParameter weight loading for fused models (
b8c3524 
vllm-project#7376)
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@dsikka @Alvant
[Bugfix] Fix PerTensorScaleParameter weight loading for fused models (
b9a405f 
vllm-project#7376)

Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsikka @mgoin