Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoRA] ReplicatedLinear support LoRA #7081

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Aug 2, 2024

As vLLM begins to continuously support an increasing number of VL models(See: #4194 (comment)), these models also need to support LoRA(See: #4194 (comment) P2).

The layers currently supporting LoRA may not fully meet the LoRA of VL models. For example, the visual encoder does not use TP , while the LLM uses TP. Therefore, supporting LoRA in ReplicatedLinear will facilitate future VL models support LoRA.

What's more, due to #6961 disable LoRA test, I conducted the relevant tests on my local server, and the results are as follows:

40c029120dd0aa9090f93ae2f1fec130

ping @Yard1
cc @ywang96 @DarkLight1337

Copy link

github-actions bot commented Aug 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@WoosukKwon WoosukKwon merged commit 99d7cab into vllm-project:main Aug 3, 2024
27 of 29 checks passed
@jeejeelee jeejeelee deleted the replicatedlinear-lora branch August 4, 2024 23:34
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants