[LoRA] ReplicatedLinear support LoRA #7081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As vLLM begins to continuously support an increasing number of VL models(See: #4194 (comment)), these models also need to support LoRA(See: #4194 (comment) P2).
The layers currently supporting LoRA may not fully meet the LoRA of VL models. For example, the
visual encoder
does not use TP , while the LLM uses TP. Therefore, supporting LoRA inReplicatedLinear
will facilitate future VL models support LoRA.What's more, due to #6961 disable LoRA test, I conducted the relevant tests on my local server, and the results are as follows:
ping @Yard1
cc @ywang96 @DarkLight1337