Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Bump transformers to 4.43.2 #6752

Merged
merged 7 commits into from
Jul 24, 2024
Merged

[Bugfix] Bump transformers to 4.43.2 #6752

merged 7 commits into from
Jul 24, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Jul 24, 2024 •
edited
Loading

FIX disabled test_config in #6690

@mgoin mgoin requested a review from ywang96 July 24, 2024 16:00
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@ywang96
Copy link
Member

ywang96 commented Jul 24, 2024 •
edited
Loading

@mgoin Thanks you for the PR! Could you uncomment the test here as well?

vllm/tests/test_config.py

Line 98 in f4f8a9d

# TODO: add these back when the rope configs are fixed

ywang96
ywang96 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgoin mgoin enabled auto-merge (squash) July 24, 2024 18:55
@simon-mo simon-mo disabled auto-merge July 24, 2024 20:22
@simon-mo simon-mo merged commit 421e218 into main Jul 24, 2024
70 of 73 checks passed
@WoosukKwon WoosukKwon deleted the transformers-4.43.2 branch July 24, 2024 21:59
cadedaniel pushed a commit to cadedaniel/vllm-public that referenced this pull request Jul 27, 2024
@mgoin @cadedaniel
[Bugfix] Bump transformers to 4.43.2 (vllm-project#6752)
3e41af6
@dtrifiro dtrifiro mentioned this pull request Aug 5, 2024
Closed
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
@mgoin
[Bugfix] Bump transformers to 4.43.2 (vllm-project#6752)
3144a11
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@mgoin @kylesayrs
[Bugfix] Bump transformers to 4.43.2 (vllm-project#6752)
5153007
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@mgoin @Alvant
[Bugfix] Bump transformers to 4.43.2 (vllm-project#6752)
8c3e200 
Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @ywang96 @simon-mo