-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Support Mamba #6484
[Model] Support Mamba #6484
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
Thank you very much for your work, I want to implement the vllm feature for RWKV, your implementation gives me a great reference. |
Hey @uniartisan, sure I can work with you to implement support for RWKV. Perhaps you could you start a draft PR, and we can talk there. Could you link your native pytorch implementation? I think it would be a good idea to start with CUDA support -- for Mamba, for instance, we depend on kernels that require CUDA, and you may run into that as well. |
I have submitted an implementation of the model code (without any adaptation for vllm; I may come back to do this in the coming week). |
Hi @tlrmchlsmth, thanks for your work! Does the current state of this PR support Codestral Mamba on vLLM yet? If so, how do you run it? |
Huggingface transformers 4.40.0 supports Mamba-2 (codestral mamba) huggingface/transformers#32080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work! This is great and will make adding new Mamba style models to vllm much easier!
Remember to add this to the Supported Models page! |
…ithub/main' into continous_batching_mamba_from_scratch
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
This is closely based on vLLM's Jamba implementation. It also has several changes and fixes to deal with the fact that there is no KV cache at all.
Changes in this PR
mamba_cache.py
Support for Mamba2, Codestral-Mamba, and FalconMamba will come in subsequent PRs.
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!