Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix usage stats logging exception warning with OpenVINO #6349

Merged

Conversation

helena-intel
Copy link
Contributor

  • Fix usage stats logging exception with OpenVINO. kv_cache_dtype is of type openvino.Type, which is not json serializable. Casting to string is the easiest fix that doesn't require an "if openvino".
  • Update minimum optimum-intel version to 1.18.1 for transformers 4.42 compatibility, which is the minimum version of transformers in requirements-common.txt

FIX #6340

cc @ilya-lavrenov

Update minimum optimum-intel version to 1.18.1 for transformers 4.42 compatibility
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DarkLight1337 DarkLight1337 merged commit adf32e0 into vllm-project:main Jul 12, 2024
71 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants