Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] try to add multi-node tests #6280

Merged
merged 29 commits into from
Jul 13, 2024
Merged

[ci] try to add multi-node tests #6280

merged 29 commits into from
Jul 13, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

@youkaichao youkaichao mentioned this pull request Jul 10, 2024
Merged
@youkaichao youkaichao requested a review from khluu July 12, 2024 04:12
khluu
khluu approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buildkite multi node script part LGTM in general! Will defer to someone else who is more familiar for the tests changes.

.buildkite/run-multi-node-test.sh Show resolved Hide resolved
.buildkite/run-multi-node-test.sh Show resolved Hide resolved
.buildkite/run-multi-node-test.sh Show resolved Hide resolved
@andoorve @youkaichao
Get rid of first if condition
9f71fb2 
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
@youkaichao youkaichao mentioned this pull request Jul 13, 2024
Closed
@youkaichao
Copy link
Member Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 13, 2024
@youkaichao youkaichao merged commit 41708e5 into vllm-project:main Jul 13, 2024
82 of 86 checks passed
@youkaichao youkaichao deleted the multinode-test branch July 13, 2024 04:51
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
@youkaichao @andoorve @dtrifiro
[ci] try to add multi-node tests (vllm-project#6280)
3bb03de 
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Co-authored-by: Muralidhar Andoorveedu <[email protected]>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@youkaichao @andoorve
[ci] try to add multi-node tests (vllm-project#6280)
d3f7d3e 
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Co-authored-by: Muralidhar Andoorveedu <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@youkaichao @andoorve @Alvant
[ci] try to add multi-node tests (vllm-project#6280)
6941749 
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Co-authored-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khluu khluu khluu approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youkaichao @khluu @andoorve