Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Guide for adding multi-modal plugins #6205

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 8, 2024

This PR adds a new guide for developing custom multi-modal plugins. The guide is mostly a placeholder atm but will become more detailed as we support more types of multi-modal data.

@DarkLight1337 DarkLight1337 requested a review from ywang96 July 8, 2024 06:24
@DarkLight1337 DarkLight1337 changed the title [Doc] New page for adding multi-modal plugin [Doc] Guide for adding multi-modal plugins Jul 8, 2024
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments!

vllm/multimodal/base.py Show resolved Hide resolved
Comment on lines +12 to +16

.. note::
This article is a work in progress.

..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could take image as an example to show how to add a new modality?

Copy link
Member Author

@DarkLight1337 DarkLight1337 Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you already had a plan for adding a tutorial (judging from the TODO comment) so I haven't written up anything yet. Perhaps we can do that in another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we can do that!

@DarkLight1337 DarkLight1337 merged commit 8a924d2 into vllm-project:main Jul 10, 2024
70 checks passed
@DarkLight1337 DarkLight1337 deleted the mm-plugin-docs branch July 10, 2024 13:09
adityagoel14 pushed a commit to adityagoel14/vllm-torchrun-test that referenced this pull request Jul 10, 2024
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants