Benchmark: add H100 suite #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I use this for some fp8 test - especially Mixtral |
|
@KuntaiDu can you please review this? I think I got it working (see link in the description) by adding bunch of clean up in the shell script |
KuntaiDu
approved these changes
Jul 9, 2024
KuntaiDu
reviewed
Jul 9, 2024
| /workspace/buildkite-agent artifact upload "$RESULTS_FOLDER/*" | ||
|
|
||
| # Use the determined command to annotate and upload artifacts | ||
| $BUILDKITE_AGENT_COMMAND annotate --style "info" --context "benchmark-results" < $RESULTS_FOLDER/benchmark_results.md |
There was a problem hiding this comment.
As the A100 benchmark also uses the same context (benchmark-results), it will overwrite the annotation. Maybe add --append parameter, or annotate in a different context (like "${gpu_name}-benchmark-results") .
| # since we are in container anyway | ||
| pkill -9 -f python | ||
| pkill -9 -f python3 | ||
|
|
There was a problem hiding this comment.
I tried pkill pt_main_thread, but I guess pkill -9 -f python3 also works.
KuntaiDu
requested changes
Jul 9, 2024
simon-mo
commented
Jul 9, 2024
KuntaiDu
reviewed
Jul 10, 2024
| /workspace/buildkite-agent artifact upload "$RESULTS_FOLDER/*" | ||
|
|
||
| # Use the determined command to annotate and upload artifacts | ||
| $BUILDKITE_AGENT_COMMAND annotate --style "info" --context "h100-benchmark-results" < $RESULTS_FOLDER/benchmark_results.md |
There was a problem hiding this comment.
--context "${gpu_type}-benchmark-results"
comaniac
approved these changes
Jul 11, 2024
|
this is awesome, thanks for adding |
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Alvant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently added an H100 agent which will be online for 12 hours per day. Let's test it out.
Successful build: https://buildkite.com/vllm/performance-benchmark/builds/4493