Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] FIx benchmark args for randomly sampled dataset #5947

Merged
merged 29 commits into from
Jul 8, 2024
Merged

[Bugfix] FIx benchmark args for randomly sampled dataset #5947

merged 29 commits into from
Jul 8, 2024

Conversation

haichuan1221
Copy link
Contributor

add benchmark testing; compared the existing test, new test has two advantages:

  1. the input is random sampled with fixed length
  2. the output is also fixed

@DarkLight1337
Copy link
Member

To speed up the CI queue, I've cancelled the distributed tests for the latest CI run in this PR since they won't pass anyway until #5905 has been merged. Now that it has been merged, please merge main into your branch so that the CI can pass once again.

@haichuan1221
Copy link
Contributor Author

To speed up the CI queue, I've cancelled the distributed tests for the latest CI run in this PR since they won't pass anyway until #5905 has been merged. Now that it has been merged, please merge main into your branch so that the CI can pass once again.

Already done this

@ywang96
Copy link
Member

ywang96 commented Jul 8, 2024

@haichuan1221 Ah looks like this is for patching the previous PR I merged, sorry that I didn't catch the error.

@ywang96 ywang96 enabled auto-merge (squash) July 8, 2024 07:33
@ywang96 ywang96 changed the title Feature/add benchmark testing [Bugfix] FIx benchmark args for randomly sampled dataset Jul 8, 2024
@ywang96 ywang96 merged commit 717f4bc into vllm-project:main Jul 8, 2024
70 checks passed
@haichuan1221
Copy link
Contributor Author

@haichuan1221 Ah looks like this is for patching the previous PR I merged, sorry that I didn't catch the error.

I didn't catch the error either, sorry for the inconvenience

xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@haichuan1221 @ywang96
Feature/add benchmark testing (vllm-project#5947)
82f9898 
Co-authored-by: Roger Wang <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@haichuan1221 @ywang96 @Alvant
Feature/add benchmark testing (vllm-project#5947)
ad9cc2a 
Co-authored-by: Roger Wang <[email protected]>
Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haichuan1221 @DarkLight1337 @ywang96