Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix detokenizer shallow copy #5919

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

aurickq
Copy link
Contributor

@aurickq aurickq commented Jun 27, 2024

Quick bugfix for Detokenizer.decode_prompt_logprobs_inplace when prev_tokens can blow up exponentially due to it being the same reference as next_iter_tokens

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@aurickq aurickq changed the title fix detokenizer shallow copy [Bugfix] fix detokenizer shallow copy Jun 27, 2024
@aurickq
Copy link
Contributor Author

aurickq commented Jun 27, 2024

@Yard1

@Yard1 Yard1 enabled auto-merge (squash) June 27, 2024 17:16
@zifeitong
Copy link
Contributor

Hi,

About

prev_tokens can blow up exponentially due to it being the same reference as next_iter_tokens

What's the behavior you are seeing? Is it caused by the bug fixed in #5846?

Thanks!

@aurickq
Copy link
Contributor Author

aurickq commented Jun 27, 2024

Hi,

About

prev_tokens can blow up exponentially due to it being the same reference as next_iter_tokens

What's the behavior you are seeing? Is it caused by the bug fixed in #5846?

Thanks!

It sounds related. I found this condition token_id == all_token_ids[token_position] didn't get triggered which caused the issue described in this PR. Does #5846 also fix this issue?

@zifeitong
Copy link
Contributor

Hi,
About

prev_tokens can blow up exponentially due to it being the same reference as next_iter_tokens

What's the behavior you are seeing? Is it caused by the bug fixed in #5846?
Thanks!

It sounds related. I found this condition token_id == all_token_ids[token_position] didn't get triggered which caused the issue described in this PR. Does #5846 also fix this issue?

I believe so. The exponentially growth will be triggered in scenarios described in #5846 (comment)

@aurickq
Copy link
Contributor Author

aurickq commented Jun 28, 2024

Hi,
About

prev_tokens can blow up exponentially due to it being the same reference as next_iter_tokens

What's the behavior you are seeing? Is it caused by the bug fixed in #5846?
Thanks!

It sounds related. I found this condition token_id == all_token_ids[token_position] didn't get triggered which caused the issue described in this PR. Does #5846 also fix this issue?

I believe so. The exponentially growth will be triggered in scenarios described in #5846 (comment)

Unfortunately it still doesn't seem to be fixed for me. I'll try to get a minimal example

@simon-mo simon-mo merged commit 23b899a into vllm-project:main Oct 22, 2024
64 of 68 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants