[Frontend] OpenAI API server: Add add_special_tokens to ChatCompletionRequest (default False)
#5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkLight1337
approved these changes
Jun 5, 2024
|
LGTM, thanks for making it configurable! |
blinkbear
pushed a commit
to blinkbear/vllm
that referenced
this pull request
Jun 6, 2024
…ionRequest (default False) (vllm-project#5278)
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
…ionRequest (default False) (vllm-project#5278)
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
…ionRequest (default False) (vllm-project#5278)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
…ionRequest (default False) (vllm-project#5278)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
…ionRequest (default False) (vllm-project#5278)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…ionRequest (default False) (vllm-project#5278)
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
…ionRequest (default False) (vllm-project#5278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4688 introduced a change to how messages are formatted into a prompt for the chat endpoint - the prompt is tokenized with
add_special_tokens=Falseso a BOS token is not added. It is assumed that the chat template takes care of adding all needed special tokens.This PR aims to make this behavior configurable instead of hardcoded. By adding
add_special_tokensas a field toChatCompletionRequest, the user can control whether a BOS token should be added or not. This is useful because not all chat templates add the BOS token.