-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Marlin_24: Ensure the mma.sp instruction is using the ::ordered_metadata modifier (introduced with PTX 8.5) #5136
Merged
simon-mo
merged 2 commits into
vllm-project:main
from
neuralmagic:marlin_24_ptx_ordered_metadata
May 31, 2024
Merged
[Kernel] Marlin_24: Ensure the mma.sp instruction is using the ::ordered_metadata modifier (introduced with PTX 8.5) #5136
simon-mo
merged 2 commits into
vllm-project:main
from
neuralmagic:marlin_24_ptx_ordered_metadata
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata modifier (introduced with PTX 8.5)
robertgshaw2-neuralmagic
approved these changes
May 30, 2024
tlrmchlsmth
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
blinkbear
pushed a commit
to blinkbear/vllm
that referenced
this pull request
May 31, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
Hi @alexm-neuralmagic, I'm going to revert this PR because it doesn't compile on CUDA 12.1 and 11.8 and our release pipeline is currently stuck there. Sorry! https://github.com/vllm-project/vllm/actions/runs/9311899829/job/25631836467#step:8:1873
|
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 31, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
blinkbear
pushed a commit
to blinkbear/vllm
that referenced
this pull request
Jun 6, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 8, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 14, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
…red_metadata modifier (introduced with PTX 8.5) (vllm-project#5136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recently released PTX 8.5 (on May 9, 2024) introduced a new modifier, called ordered_metadata, for the mma.sp 2:4 warp sparse instruction. This modifier requires that the indices in the sparsity metadata are sorted in an increasing order starting from the LSB bit. In our case, in format_24.py lines 96-102, we already have this requirement met due to the following encodings:
Therefore, we can simply add the new modifier and nothing else is required.