-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Fixup for CUTLASS kernels in CUDA graphs #4954
[Kernel] Fixup for CUTLASS kernels in CUDA graphs #4954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is it possible to have a test covered?
@alexm-neuralmagic could you describe the issue you ran into with CUDA Graphs and the Marlin kernels so I can try to recreate the problem with a unit test? BTW I don't think anyone has actually run into an issue here, so I'd like to make sure I'm actually fixing something before landing :) |
Without the cuda stream parameter eager_mode=False did not work. You can try with eager_mode False and see if all works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments before merge
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs
Pass the CUDA stream into the CUTLASS GEMMs, to avoid future issues with CUDA graphs, like we do in the marlin kernels here:
vllm/csrc/quantization/marlin/sparse/marlin_24_cuda_kernel.cu
Lines 1103 to 1107 in 757b62c
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!