Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix CLI arguments in OpenAI server docs #4709

Merged
merged 1 commit into from
May 9, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 9, 2024

vllm-openai-server command is not defined so the documentation failed to generate the sphinx-argparse docs. In the future, this patch should be replaced by the changes made by #4167.

FIX #4522
FIX #4707

@simon-mo simon-mo merged commit a3c1245 into vllm-project:main May 9, 2024
53 of 55 checks passed
@simon-mo
Copy link
Collaborator

simon-mo commented May 9, 2024

@simon-mo
Copy link
Collaborator

simon-mo commented May 9, 2024

Build log here https://readthedocs.org/projects/vllm/builds/24329938/ but i'm not sure what happened...

@DarkLight1337 DarkLight1337 deleted the fix-openai-docs branch May 10, 2024 02:38
@AllenDou
Copy link
Contributor

#4729 @simon-mo

robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 19, 2024
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request May 21, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: OpenAI Server Command Line Args Broken [Doc]: Documentation disappeared
4 participants