Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm][Hardware][AMD] Adding Navi21 to fallback to naive attention if Triton is not used #4658

Merged
merged 2 commits into from
May 18, 2024

Conversation

alexeykondrat
Copy link
Contributor

Navi3X - have major HW version 11, Navi21/Navi10 have HW version 10, MI series - HW version 9.

https://github.com/ROCm/FasterTransformer-Internal/issues/247

@WoosukKwon WoosukKwon added the rocm label May 7, 2024
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeykondrat Thank for submitting the PR! Could you please fix the comment a bit? Thanks!

vllm/attention/backends/rocm_flash_attn.py Outdated Show resolved Hide resolved
@WoosukKwon WoosukKwon enabled auto-merge (squash) May 18, 2024 04:03
@WoosukKwon WoosukKwon merged commit c0724fc into vllm-project:main May 18, 2024
59 checks passed
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 19, 2024
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request May 21, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
@alexeykondrat alexeykondrat deleted the navi-fix branch September 11, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants