Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Add support for IBM Granite Code models #4636

Merged
merged 2 commits into from
May 12, 2024
Merged

[Model] Add support for IBM Granite Code models #4636

merged 2 commits into from
May 12, 2024

Conversation

yikangshen
Copy link
Contributor

To support IBM Granite Code 3B and 8B models, this PR adds MLP bias and tie word embedding support to the llama architecture.

@mayank31398
Copy link

@WoosukKwon any updates on this?
Can we add support for Granite soon?

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting the PR!

@WoosukKwon WoosukKwon merged commit 6eaccb7 into vllm-project:main May 12, 2024
59 checks passed
@njhill
Copy link
Member

njhill commented May 12, 2024

Thank you @yikangshen @WoosukKwon!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants