-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Quantized lm-head Framework #4442
[CORE] Quantized lm-head Framework #4442
Conversation
…d positional argument: 'params_dtype'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
tests/conftest.py
Outdated
@@ -437,7 +437,7 @@ def __init__( | |||
self.model = LLM( | |||
model=model_name, | |||
tokenizer=tokenizer_name, | |||
trust_remote_code=True, | |||
trust_remote_code="falcon" not in model_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have to re-download Falcon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trust_remote_code
did not work for falcon, not sure why
tests/models/test_models_logprobs.py
Outdated
|
||
MAX_MODEL_LEN = 1024 | ||
|
||
MODELS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long does it take to run all models listed here? Can some of them be removed to reduce the CI time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can just remove them. I just wanted to prove the accuracy was right
Co-authored-by: Robert Shaw <[email protected]> Co-authored-by: ZX <[email protected]>
Co-authored-by: Robert Shaw <[email protected]> Co-authored-by: ZX <[email protected]>
Co-authored-by: Robert Shaw <[email protected]> Co-authored-by: ZX <[email protected]>
@robertgshaw2-neuralmagic @Yard1 it looks like there was some impact from this ... not sure if it actually exposed a latent bug where the lm_head for gpt_bigcode (and similar) was not previously adaptable: #6314 |
@njhill do you know if this was working before? |
Co-authored-by: Robert Shaw <[email protected]> Co-authored-by: ZX <[email protected]>
hi!is 'look into quantized embeddings' available now? looking forward to this! |
Co-authored-by: Robert Shaw <[email protected]> Co-authored-by: ZX <[email protected]> Signed-off-by: Alvant <[email protected]>
MOTIVATION
SUMMARY:
IMPLEMENTATION:
VocabParallelEmbedding
to usecreate_weights
to create the parametersParallelLMHead
to useapply()
to generate outputquant_config
intoParallelLMHead
lm-head
if detected in configFOLLOW UPS:
TEST MODEL: (quantized by auto-round and load tested with autogptq):
https://github.com/intel/auto-round/blob/8a3da144423322dfedb0b3fa702ae35d242496d8/docs/Meta-Llama-3-8B-Instruct-acc.md?plain=1#L3
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!