Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable non-lazy string operation on logging #4326

Merged
merged 9 commits into from
Apr 26, 2024
Merged

[CI] Disable non-lazy string operation on logging #4326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e1e567e
done
rkooo567 Apr 24, 2024
0f92b19
Fix logging lint errors
Apr 24, 2024
e27e61e
Merge pull request #20 from tdg5/exp-2
rkooo567 Apr 24, 2024
08beb2e
Fix more logging lint errors
Apr 25, 2024
36cf873
Merge pull request #21 from tdg5/exp-2
rkooo567 Apr 25, 2024
09e6979
done
rkooo567 Apr 25, 2024
3d67a8b
Merge branch 'main' into exp
rkooo567 Apr 25, 2024
ead5360
Merge branch 'upstream-main' into exp
Apr 25, 2024
aacd744
Merge pull request #22 from tdg5/exp-2
rkooo567 Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ select = [
"SIM",
# isort
# "I",
"G",
]
ignore = [
# star imports
Expand Down
10 changes: 6 additions & 4 deletions vllm/core/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,9 @@ def _schedule_prefills(

if num_new_tokens > self.prompt_limit:
logger.warning(
f"Input prompt ({num_new_tokens} tokens) is too long"
f" and exceeds limit of {self.prompt_limit}")
"Input prompt (%d tokens) is too long"
" and exceeds limit of %d", num_new_tokens,
self.prompt_limit)
for seq in waiting_seqs:
seq.status = SequenceStatus.FINISHED_IGNORED
ignored_seq_groups.append(seq_group)
Expand All @@ -631,8 +632,9 @@ def _schedule_prefills(
break
elif can_allocate == AllocStatus.NEVER:
logger.warning(
f"Input prompt ({num_new_tokens} tokens) is too long"
f" and exceeds the capacity of block_manager")
"Input prompt (%d tokens) is too long"
" and exceeds the capacity of block_manager",
num_new_tokens)
for seq in waiting_seqs:
seq.status = SequenceStatus.FINISHED_IGNORED
ignored_seq_groups.append(seq_group)
Expand Down
Loading