Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]: Update the page of adding new models #4236

Merged
merged 2 commits into from
Apr 21, 2024
Merged

[Doc]: Update the page of adding new models #4236

merged 2 commits into from
Apr 21, 2024

Conversation

YeFD
Copy link
Contributor

@YeFD YeFD commented Apr 21, 2024

The _MODEL_REGISTRY in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update.

FIX #4235

The `_MODEL_REGISTRY`  in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update about .
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@youkaichao youkaichao enabled auto-merge (squash) April 21, 2024 07:02
@youkaichao
Copy link
Member

@YeFD please fix the documentation error, thanks!

The `_MODEL_REGISTRY`  in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update about .
auto-merge was automatically disabled April 21, 2024 07:56

Head branch was pushed to by a user without write access

@youkaichao youkaichao merged commit 7f2593b into vllm-project:main Apr 21, 2024
47 checks passed
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
ZackBradshaw pushed a commit to ZackBradshaw/vllm that referenced this pull request Apr 22, 2024
ZackBradshaw pushed a commit to ZackBradshaw/vllm that referenced this pull request Apr 22, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Apr 25, 2024
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
alexeykondrat pushed a commit to alexeykondrat/ci-vllm that referenced this pull request May 1, 2024
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 7, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Need to update the page of adding new models
2 participants