-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc]: Update the page of adding new models #4236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_MODEL_REGISTRY` in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update about .
youkaichao
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
@YeFD please fix the documentation error, thanks! |
The `_MODEL_REGISTRY` in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update about .
auto-merge was automatically disabled
April 21, 2024 07:56
Head branch was pushed to by a user without write access
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 21, 2024
ZackBradshaw
pushed a commit
to ZackBradshaw/vllm
that referenced
this pull request
Apr 22, 2024
ZackBradshaw
pushed a commit
to ZackBradshaw/vllm
that referenced
this pull request
Apr 22, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Apr 25, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 26, 2024
alexeykondrat
pushed a commit
to alexeykondrat/ci-vllm
that referenced
this pull request
May 1, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_MODEL_REGISTRY
in vllm/model_executor/model_loader.py was removed, and documentation of registering models needs to update.FIX #4235