-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] [Core] perf: Automatically detect vLLM-tensorized model, update tensorizer
to version 2.9.0
#4208
[Frontend] [Core] perf: Automatically detect vLLM-tensorized model, update tensorizer
to version 2.9.0
#4208
Conversation
WIP because the codes needs to be cleaned up, and the current work refactoring the example script in to importable functions from `tensorizer.py` is still in progress, which will allow for better forward compatibility and better testing.
Some QoL improvements for |
…-update # Conflicts: # docs/source/models/engine_args.rst
Will take a look once I have some bandwidth - thanks for the continuous contribution to vLLM! |
…-update # Conflicts: # requirements-dev.txt # setup.py # tests/tensorizer_loader/tensorize_vllm_model_for_testing.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sangstar for the continuous contribution! I left some questions.
@ywang96 Resolved comments! Let me know if anything else is needed. |
…-update # Conflicts: # vllm/model_executor/model_loader/loader.py
@ywang96 Resolved comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
@ywang96 Checks passed and ready to merge! 😄 |
…pdate `tensorizer` to version 2.9.0 (vllm-project#4208)
…pdate `tensorizer` to version 2.9.0 (vllm-project#4208)
…pdate `tensorizer` to version 2.9.0 (vllm-project#4208)
Automatically detect vLLM-tensorized model, update
tensorizer
to version 2.9.0This PR accomplishes several things:
tensorize_vllm_examples.py
example script, and slight corrections to the docstrings of the new, refactored functions.vllm_tensorized
as an arg has been removed.tensorizer
to the full release of 2.9.0.PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!