[Core] Add integrity check during initialization; add test for it #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Apr 18, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 21, 2024
[Core] Add integrity check during initialization; add test for it (vllm-project#4155)
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
[Core] Add integrity check during initialization; add test for it (vllm-project#4155)
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 26, 2024
[Core] Add integrity check during initialization; add test for it (vllm-project#4155)
alexeykondrat
pushed a commit
to alexeykondrat/ci-vllm
that referenced
this pull request
May 1, 2024
[Core] Add integrity check during initialization; add test for it (vllm-project#4155)
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
[Core] Add integrity check during initialization; add test for it (vllm-project#4155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move to vllm-managed nccl, users have reported incompletely downloaded nccl library due to network issues. This will lead to core dump, and is not easy to debug. See #3916 .
This PR adds integrity check during initialization, in another process by
os.system. If the process crashes, we will know and give warnings to users.In addition, this PR adds tests for the corruption and environment variable to set the library path.