Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] handle hf_config with architectures == None #3982

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[Bugfix] handle hf_config with architectures == None #3982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1ede1c
[Bugfix] handle hf_config with architectures == None
tjohnson31415 Apr 10, 2024
82fa5e3
Apply suggestions from code review
simon-mo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vllm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ def _verify_load_format(self) -> None:

# TODO: Remove this check once HF updates the pt weights of Mixtral.
architectures = getattr(self.hf_config, "architectures", [])
if "MixtralForCausalLM" in architectures and load_format == "pt":
# architectures can be None instead of []
if architectures and "MixtralForCausalLM" in architectures \
simon-mo marked this conversation as resolved.
Show resolved Hide resolved
and load_format == "pt":
raise ValueError(
"Currently, the 'pt' format is not supported for Mixtral. "
"Please use the 'safetensors' format instead. ")
Expand Down
Loading