[Bugfix] Fix ipv6 address parsing bug #3641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a pure IPv6 environment, the
get_distributed_init_method
function invllm/utils.py
returns a URL such as "tcp://2001:4860:4860::8888:8086", where "2001:4860:4860::8888" is the IP address. This format leads to an error whenurllib.parse.urlparse
attempts to parse the URL and extract the port number:We can resolve this issue by constructing the URL with square brackets around the IPv6 address, like so: "tcp://[2001:4860:4860::8888]:8086". With this format, the port is correctly parsed:
This fix addresses a new bug encountered following the fix for issue #2685