Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmark] Change mii to use persistent deployment and support tensor parallel #3628

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

IKACE
Copy link
Contributor

@IKACE IKACE commented Mar 26, 2024

Description

When running benchmarks/benchmark/benchmark_throughput.py using deepspeed-mii backend, the original code uses non-persistent pipeline deployment, which does not support tensor parallelism and will generate errors when tp > 1.

Solution

Change deepspeed-mii backend to use persistent deployment.

The code is verified using Llama-2-7b and 4 A100 GPUs. After the change, tensor parallelism (e.g. tp=4) can be correctly supported for deepspeed-mii backend. I also compared performance of running Llama-2-7b on single A100 GPU and the throughput performance is the same as running with non-persistent deployment.

The use of persistent deployment is also encouraged in DeepSpeed's benchmark. (link)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@simon-mo
Copy link
Collaborator

@WoosukKwon i recall originally there were some issue with this approach but I don't remember exactly. Do you think this is okay?

@WoosukKwon
Copy link
Collaborator

To my understanding, the persistent deployment will involve the overhead of handling the requests, while the purpose of benchmark_throughput.py is to get the purse performance of the engine without the overhead.

@IKACE
Copy link
Contributor Author

IKACE commented Mar 27, 2024

I think the problem for non-persistent pipeline is that it does not support tuning tensor parallel degree when invoked (to my understanding). It seems that we need to wrap the program with deepspeed launcher according to this post.

@ywang96
Copy link
Member

ywang96 commented Mar 27, 2024

FYI - The way deepspeed-mii works is slightly different from vllm or tensorrt-llm since its inference engine is essentially taken from deepspeed and the batching logic happens on the deepspeed-mii layer instead of on engine itself. That's why unlike LLM from vLLM, their client object is essentially an API server/persistent deployment under the hood.

@simon-mo simon-mo merged commit 98a42e7 into vllm-project:main Mar 29, 2024
32 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 31, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants