Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Revert "[Bugfix] use SoftLockFile instead of LockFile (#3578)" #3599

Merged
merged 3 commits into from
Mar 25, 2024
Merged

[Bugfix] Revert "[Bugfix] use SoftLockFile instead of LockFile (#3578)" #3599

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da99ffe
Revert "[Bugfix] use SoftLockFile instead of LockFile (#3578)"
WoosukKwon Mar 24, 2024
a1aba04
avoid conflict with existing user lock; use mode 666 and system level…
youkaichao Mar 25, 2024
f2c122c
add /tmp as default
youkaichao Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/model_executor/weight_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def get_lock(model_name_or_path: str, cache_dir: Optional[str] = None):
lock_dir = cache_dir if cache_dir is not None else _vllm_filelocks_path
os.makedirs(os.path.dirname(lock_dir), exist_ok=True)
lock_file_name = model_name_or_path.replace("/", "-") + ".lock"
lock = filelock.SoftFileLock(os.path.join(lock_dir, lock_file_name))
lock = filelock.FileLock(os.path.join(lock_dir, lock_file_name))
return lock


Expand Down
Loading