Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] typo fix: is_hip --> is_hip() #3595

Merged
merged 4 commits into from
Mar 24, 2024
Merged

[CI] typo fix: is_hip --> is_hip() #3595

merged 4 commits into from
Mar 24, 2024

Conversation

youkaichao
Copy link
Member

Fix a typo in function call

@youkaichao
Copy link
Member Author

hhh funny things happened, NUM_BLOCKS = [1024, 36000] not only breaks rocm but also breaks cuda, but we used to only test with NUM_BLOCKS = [1024, 10000] because not is_hip is always False (is_hip is a function).

zhuohan123
zhuohan123 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix! I guess the test failure is due to L4's limited memory size?

@youkaichao youkaichao merged commit 8b268a4 into vllm-project:main Mar 24, 2024
32 checks passed
@youkaichao
Copy link
Member Author

Our test is run in L4 machine, and previous test succeeded because they use [1024, 10000]. We never tested [1024, 36000] because not is_hip is always False, or is_hip is always True.

@youkaichao youkaichao deleted the youkaichao-typo-fix branch March 24, 2024 23:04
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
@youkaichao
[CI] typo fix: is_hip --> is_hip() (vllm-project#3595)
a7144e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @zhuohan123