Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue templates #3436

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix issue templates #3436

merged 3 commits into from
Mar 15, 2024

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Mar 15, 2024

The tagging of newly created issues wasn't working and this PR partially fixes it.

Issues:

  • Putting [Type]: at the start of the title is unnecessary because, if the labelling is done correctly, it'll be at the end anyway, like this:
    image
  • Some of the labels specified in the templates don't exist, so they can't be applied to the newly created issues

Solutions:

  • Remove [Type]: from templates
  • Change doc -> documentation, which does exist
  • Change feature -> enhancement, which does exist

Some aspects cannot be fixed with a PR and need to be done by someone with write access to the repo (documentation for this):

  • Remove the label Installation and replace it with a label installation
  • Remove the label feature request and adopt the default enhancement label
  • Create the usage label
  • Create the misc label
  • Take the opportunity to delete some old/unused labels to reduce clutter (there are currently 34 in total but we only have 8 types of issue)

@youkaichao
Copy link
Member

@hmellor Thanks for your contribution!

W.r.t. the title, we would like to keep them. Sometimes we get notifications from email, and the title makes it clear.

W.r.t. the label, I created new labels, and would be happy to accept the following changes:

  • Change doc -> documentation, which does exist
  • Change feature -> feature request, which does exist

Can you update your PR to meet the above requirements?

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simon-mo simon-mo enabled auto-merge (squash) March 15, 2024 20:31
@simon-mo simon-mo merged commit a7af453 into vllm-project:main Mar 15, 2024
24 checks passed
@hmellor hmellor deleted the fix-issue-templates branch March 15, 2024 21:36
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants