-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] PR templates #3413
[Misc] PR templates #3413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a section on tagging relevant issues.
I also prefer to keep most of these as HTML comments to keep PR clean.
Let's add the following section about RFC: If the changes are big, create or tag the RFC issue. |
@simon-mo how about this mixture of HTML and markdown?
|
The good thing is that we can collapse the "must-to-read" section (n.b. inside this section only html is allowed, markdown rendering does not work). This way, PR looks clean, and we convey the message to contributors (hopefully they will expand and read the section). |
|
I am reviewing this PR as well! Please do not merge it yet :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left initial round of comments. Will also push more changes after these comments being fixed.
Co-authored-by: Zhuohan Li <[email protected]>
Co-authored-by: Zhuohan Li <[email protected]>
Co-authored-by: Zhuohan Li <[email protected]>
Co-authored-by: Zhuohan Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a pass over the PR template. @youkaichao can you take a final pass and possibly we can merge this?
Co-authored-by: Zhuohan Li <[email protected]>
Add a PR template with guidelines for contributors.
Preview at https://github.com/youkaichao/vllm/blob/main/.github/PULL_REQUEST_TEMPLATE.md .