Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Add support for Qwen2MoeModel #3346

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

wenyujin333
Copy link
Contributor

Recently, the new codes of Qwen2MoE to Hugging Face Transformers, and thus I would love to contribute the new model to vLLM as well.

In this PR, I have provided the implementation of Qwen2MoE model and add some notes on it.

@wenyujin333 wenyujin333 marked this pull request as ready for review March 28, 2024 07:26
@JustinLin610
Copy link
Contributor

@simon-mo hi, our codes are merged into HF transformers already. would you mind taking a look?

@WoosukKwon WoosukKwon requested a review from esmeetu March 28, 2024 08:32
@WoosukKwon
Copy link
Collaborator

@esmeetu Could you take a look?

@wenyujin333 wenyujin333 changed the title add qwen2moe [Model] Add support for Qwen2MoeModel Mar 28, 2024
Copy link
Collaborator

@esmeetu esmeetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments. And this look good to me.

vllm/model_executor/models/qwen2_moe.py Outdated Show resolved Hide resolved
@esmeetu esmeetu enabled auto-merge (squash) March 28, 2024 12:21
@wenyujin333
Copy link
Contributor Author

@esmeetu it seems some unrelated tests failed, should we rerun it? or could you just merge this directly?

@esmeetu esmeetu disabled auto-merge March 28, 2024 13:13
@esmeetu
Copy link
Collaborator

esmeetu commented Mar 28, 2024

@wenyujin333 There's a required check failed. Can you trigger this CI check again by submit a empty commit?

@esmeetu esmeetu enabled auto-merge (squash) March 28, 2024 15:03
@esmeetu esmeetu merged commit d6ea427 into vllm-project:main Mar 28, 2024
33 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 31, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants