[BugFix] Fix async engine running on ray #3343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rkooo567 |
rkooo567
reviewed
Mar 13, 2024
This thing hits a strange corner case. It will only be wrong when we run async engines distributedly with ray. We should add a test on this. |
|
@cadedaniel for our internal version, do we have unit test for this case? I'd love to upstream it if there is |
|
@rkooo567 we have https://github.com/anyscale/vllm/blob/main/tests/async_engine/test_api_server.py#L36-L45 and https://github.com/anyscale/vllm/blob/main/.buildkite/ci/run_distributed_test.sh#L18-L23, but I don't think either have ray dag enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A parameter is missing:
use_ray_compiled_daginRayGPUExecutorAsyncafter merging #3191.@zhuohan123 Could you help test this whether is ok when
use_ray_compiled_dag=True, please. Because that feature doesn't work on my machine. It seems aDevelopAPIin ray.